Fix crash caused by teleporting using Iron's Teleport scroll#700
Fix crash caused by teleporting using Iron's Teleport scroll#700gjorgdy wants to merge 2 commits into
Conversation
|
|
…d to the plot grid of an unloaded sublevel
|
Is there a reason why your PR is for main rather than your feature/irons-compat branch? In my brief testing I was able to teleport without issue using a build based off of that branch, including with portal frames. It seems that it is a better fix for this issue. I'm planning on testing it on a server with around 8 players over the next few days and would be happy to report any feedback if it is wanted. |
|
I initially also made another PR with that "irons-compat" branch, but the Sable devs said they would prefer to not have to maintain support for Irons and that it should be fixed on that mod itself. This PR is a generic fix to teleportation and should also fix other mods without requiring to add implicit compatibility. |
|
I'm seeing another issue here where the teleport using portal frames fails if the sublevel is too far way in an unloaded chunk. Is this possible to fix? |
4 participants
The mixin for player teleportation did not cover all possible teleport methods the class contains. One of these methods which was not covered is called by Iron's Spells and Spellbooks to teleport using the teleport and the portal spells.
A small other issue still persists, portal frames only being to teleport players to sublevels, but not detecting player collision when the frame is in a sublevel. I am not quite sure if this is an issue caused by Iron's or by Sable at this moment.
Closes #496